Closed
Conversation
1 task
12 tasks
Just-Kiel
reviewed
Jul 25, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Could it be great to have "Delete Environment" button ? Like the "Delete Data" |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
added in todos for next version. Could be added to the "manage installed plugins" page, alongside the "un-install plugin" button |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mh0g
force-pushed
the
dev/plugin_system
branch
2 times, most recently
from
8a21540 to
61d8a15
Compare
Just-Kiel
reviewed
Aug 23, 2024
mh0g
force-pushed
the
dev/plugin_system
branch
2 times, most recently
from
ea95d40 to
b7f9a2f
Compare
mh0g
force-pushed
the
dev/plugin_system
branch
from
66e7532 to
fab1b8e
Compare
added 2 commits
September 30, 2024 15:16
mh0g
force-pushed
the
dev/plugin_system
branch
from
0e26264 to
fa47004
Compare
added 3 commits
October 8, 2024 11:11
added back menu after update fix for existing symlink
mh0g
force-pushed
the
dev/plugin_system
branch
from
f98790b to
24c4585
Compare
added 3 commits
October 10, 2024 13:38
added build badge changes for uid renaming added back menu after update fix for existing symlink
Member
|
Would it be possible to add support for non-default location for conda environments? i.e. using "--prefix PATH" instead of "--name NAME". Meshroom/meshroom/core/plugin.py Line 90 in 24c4585 would become: cmd = condaBin+" list --prefix "+envName, or alternatively by checking the result of conda env list.
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feature adds a plugin system to meshroom.
It also allows to install and run new nodes using containerization tools, such as conda and docker.
Features list
v1
v2
v3
Implementation remarks
The logic is in meshroom/core/plugin.py .
It defines a new node classes to run python code in environments/containers using meshroom_compute.
Added bandit file to not test the shell call errors in codefactor.
Uses the CI en var to skip the tests on CI.
Future needed work: ui part to list/uninstall catalog, multiples envs per node, button to delete env